Simplify hiding navigation items slightly

The code is now a bit longer, but it's also a bit clearer. The resulting
HTML is also clearer.

1 files changed, 9 insertions, 4 deletions

diff --git a/html/@include.php b/html/@include.php
index 2cf50d3..3966ec0 100644
--- a/html/@include.php
+++ b/html/@include.php
@@ -26,11 +26,16 @@ function site_head($title) {
 function site_navitem($url, $text, $hide = false) {
 	$selected = $url == $_SERVER['REQUEST_URI'];
 
-	$hbeg = $hide && !$selected ? '!--' : '';
-	$hend = $hide && !$selected ? '--' : '';
-	$sel = $selected ? ' class="selected"' : '';
+	$classes = [];
+	if ($selected) {
+		$classes[] = "selected";
+	}
+	if ($hide && !$selected) {
+		$classes[] = "hidden";
+	}
+	$classes = count($classes) > 0 ? (" class=\"" . implode(" ", $classes) . "\"") : "";
 
-	return "<{$hbeg}li{$sel}><a href=\"{$url}\">{$text}</a></li{$hend}>";
+	return "<li{$classes}><a href=\"{$url}\">{$text}</a></li>";
 }
 
 /// Get the standard page header elements for the site