Age | Commit message (Collapse) | Author |
|
Explicitly specify void when a function accepts no arguments.
|
|
PATH_MAX is not guaranteed by POSIX to be present and some systems, like
GNU Hurd, indeed does not define it.
http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/limits.h.html
https://www.gnu.org/software/hurd/hurd/porting/guidelines.html
For now let's define PATH_MAX as 4096 (if it is not already defined),
because that's how Linux defines it and it seems quite reasonable.
In future dependence on PATH_MAX can be removed.
|
|
Wrong type has been used for calculating size of requested memory.
Underallocation happened in mentries_fromfile() code path if
sizeof(ssize_t) > sizeof(int), which is true on 64-bit platforms.
Reading metadata file with extended attributes entries led to corruption
of metadata represented in memory on such platforms, so applying could
led to corruption of metadata on disk too.
Reported-by: Uros Juvan <asmpro@gmail.com>
|
|
|
|
|
|
|
|
getxattr() call can fail in mentry_create(), so NULL-initialize
mentry->xattr_values[i] and update mentry->xattrs upon error, so there
is no attempt in mentry_free() to free unitialized xattr_names[i] and
xattr_values[i] pointers.
Fixes #38.
|
|
|
|
As a bonus you can build out-of-tree now via make -f.
It's part of the work related to issue #22.
|